Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Parametrize sssctl tests. #2

Closed
wants to merge 5 commits into from
Closed

Conversation

dkarpele
Copy link
Collaborator

@dkarpele dkarpele commented Dec 9, 2024

  • Combine various sssctl tests to the single parametrized tests.
  • Mark bash sssctl tests that duplicates other tests with -:.
  1. test_sssctl__check_invalid_option_name_in_snippet merges tests:

test_sssctl__check_invalid_option_name_in_snippet
test_sssctl__check_invalid_section_in_name_in_snippet

  1. test_sssctl__check_invalid_section_name merges tests:

test_sssctl__check_missing_equal_sign
test_sssctl__check_invalid_id_provider
test_sssctl__check_missing_id_provider
test_sssctl__check_special_character_in_option_name
test_sssctl__check_special_character_in_section_name
test_sssctl__check_special_character_in_domain_name
test_sssctl__check_forward_slash_missing_in_domain_section
test_sssctl__check_invalid_sssd_section_name
test_sssctl__check_missing_closing_bracket
test_sssctl__check_missing_opening_bracket

  1. test_sssctl__check_attribute_not_allowed_in_sssd merges tests:

test_sssctl__check_misplaced_option
test_sssctl__check_ldap_host_object_class_not_allowed_in_sssd

  1. test_sssctl__check_config_location_permissions merges tests:

test_sssctl__check_non_existing_snippet
test_sssctl__check_non_default_config_location_missing_snippet_directory
test_sssctl__check_invalid_permission
test_sssctl__check_non_default_config_location_invalid_permission
test_sssctl__check_non_default_config_location_invalid_option_name

  1. Dropped tests:
    test_sssctl__check_invalid_pam_section_name (duplicate test_sssctl__check_invalid_sssd_section_name)
    test_sssctl__check_invalid_nss_section_name (duplicate test_sssctl__check_invalid_sssd_section_name)

- Combine various sssctl tests to the single parametrized tests.
- Mark bash sssctl tests that duplicates other tests with `-:`.

Signed-off-by: Denis Karpelevich <[email protected]>
@dkarpele dkarpele requested a review from danlavu December 9, 2024 17:16
@dkarpele dkarpele self-assigned this Dec 9, 2024
@dkarpele
Copy link
Collaborator Author

Closing in favour of SSSD#7776

@dkarpele dkarpele closed this Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant